Messages in this thread |  | | Date | Thu, 16 Apr 2015 00:30:51 +0100 | From | Al Viro <> | Subject | Re: [PATCH 1/3] direct-io: only inc/dec inode->i_dio_count for file systems |
| |
On Wed, Apr 15, 2015 at 05:05:48PM -0600, Jens Axboe wrote: > On 04/15/2015 04:56 PM, Al Viro wrote: > >On Thu, Apr 16, 2015 at 08:36:20AM +1000, Dave Chinner wrote: > > > >>Bikeshedding: I think this would be better suited to inode_dio_begin() > >>and inode_dio_end() because now we are trying to say "this is where > >>the DIO starts, and this is where it ends". It's not really > >>"reference counting" interface, we're trying to annotate the > >>boundaries of where DIO iis protected against truncate.... > > > >*nod* > > > >And while we are at, inode_dio_begin() could be static inline just fine. > > Done (rename and docbook), and inode_dio_{begin.end}() made static inlines. > > v3 against vfs-next attached.
Applied.
|  |