Messages in this thread |  | | Date | Wed, 15 Apr 2015 17:22:27 -0400 (EDT) | Subject | Re: [patch v2] net: hip04: Make tx coalesce timer actually work | From | David Miller <> |
| |
From: Thomas Gleixner <tglx@linutronix.de> Date: Tue, 14 Apr 2015 21:42:42 +0200 (CEST)
> The code sets the expiry value of the timer to a relative value and > starts it with hrtimer_start_expires. That's fine, but that only works > once. The timer is started in relative mode, so the expiry value gets > overwritten with the absolut expiry time (now + expiry). > > So once the timer expired, a new call to hrtimer_start_expires results > in an immidiately expired timer, because the expiry value is > already in the past. > > Use the proper mechanisms to (re)start the timer in the intended way. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Applied, thanks Thomas.
|  |