lkml.org 
[lkml]   [2015]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer
On Wed, 15 Apr, at 11:56:05AM, Roy Franz wrote:
> Yeah, I guess it shouldn't surprise me that there is support for 64
> bit addresses there :)
>
> I'l spin another patch that sets boot_params->ext_cmd_line_ptr with
> the upper 32 bits of the address.
> Should I conditionalize this with #ifdef CONFIG_X86_64, or just do it
> unconditionally, with it being a NOP
> on 32 bit? (I guess I may end up with an extra cast for the 32 bit case)

Unconditionally is best, I'm loathe to introduce #ifdefs unless
absolutely necessary.

Thanks!

--
Matt Fleming, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-04-15 22:41    [W:0.063 / U:11.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site