Messages in this thread |  | | Date | Wed, 15 Apr 2015 08:32:56 +0200 | Subject | Re: [patch 02/39] hrtimer: Get rid of the resolution field in hrtimer_clock_base | From | Frans Klaver <> |
| |
On Wed, Apr 15, 2015 at 8:29 AM, Frans Klaver <fransklaver@gmail.com> wrote: > On Tue, Apr 14, 2015 at 11:08 PM, Thomas Gleixner <tglx@linutronix.de> wrote: >> The field has no value because all clock bases have the same >> resolution. The resolution only changes when we switch to high >> resolution timer mode. We can evaluate that from a single static >> variable as well. In the !HIGHRES case its simply a constant. >> >> Export the variable, so we can simplify the usage sites. > > There seems to be only one usage site outside hrtimer.c itself. That > one only reads the value.
OK, this is incorrect. Still, if it's only meant to be read from outside hrtimer.c:
> Wouldn't it make sense to keep the variable > from the interface and use a read function instead?
Thanks, Frans
|  |