lkml.org 
[lkml]   [2015]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH v2 05/13] usb: otg: add OTG core
On 15/04/15 12:29, Paul Bolle wrote:
> (This will go into a minor detail. That's probably not what you want
> when posting an RFC. But this patch got caught by an email filter I use
> and a future, non-RFC, version will get caught too. So I decided to
> bother you with this now.)
>
> On Tue, 2015-04-14 at 13:41 +0300, Roger Quadros wrote:
>> --- a/drivers/usb/common/Makefile
>> +++ b/drivers/usb/common/Makefile
>
>> +obj-$(CONFIG_USB_OTG_CORE) += usb-otg.o
>
> This creates a module usb-otg.ko if CONFIG_USB_OTG_CORE is 'm', built
> from just usb-otg.c.
>
>> --- /dev/null
>> +++ b/drivers/usb/common/usb-otg.c
>
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>
>> +EXPORT_SYMBOL_GPL(usb_otg_register);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_unregister);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_sync_inputs);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_kick_fsm);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_register_hcd);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_unregister_hcd);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_register_gadget);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_unregister_gadget);
>
>> +EXPORT_SYMBOL_GPL(usb_otg_fsm_to_dev);
>
> This code adds no MODULE_LICENSE() macro in this patch and usb-otg.ko
> will carry no license field. So I think the loading of that module
> (triggered by loading another module that uses one of the exported
> symbols, I suppose) taints the kernel. Am I correct?

Right. I will fix this. Thanks.

cheers,
-roger



\
 
 \ /
  Last update: 2015-04-15 16:01    [W:0.172 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site