Messages in this thread |  | | From | Arnd Bergmann <> | Subject | Re: [patch v2] net: hip04: Make tx coalesce timer actually work | Date | Wed, 15 Apr 2015 12:20:01 +0200 |
| |
On Tuesday 14 April 2015 21:42:42 Thomas Gleixner wrote: > The code sets the expiry value of the timer to a relative value and > starts it with hrtimer_start_expires. That's fine, but that only works > once. The timer is started in relative mode, so the expiry value gets > overwritten with the absolut expiry time (now + expiry). > > So once the timer expired, a new call to hrtimer_start_expires results > in an immidiately expired timer, because the expiry value is > already in the past. > > Use the proper mechanisms to (re)start the timer in the intended way. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: dingtianhong <dingtianhong@huawei.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Zhangfei Gao <zhangfei.gao@linaro.org> > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Cc: netdev@vger.kernel.org >
Acked-by: Arnd Bergmann <arnd@arndb.de>
|  |