lkml.org 
[lkml]   [2015]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings
On Mon, Apr 13, 2015 at 11:47:36PM +0200, Mateusz Kulikowski wrote:
> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
> Replace printk() with pr_* where possible.
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib.h | 4 +-
> drivers/staging/rtl8192e/rtllib_crypt.c | 17 ++++----
> drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 59 +++++++++++-----------------
> drivers/staging/rtl8192e/rtllib_rx.c | 4 +-
> 4 files changed, 34 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 472e880..fd7b7a5 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -685,13 +685,13 @@ extern u32 rtllib_debug_level;
> #define RTLLIB_DEBUG(level, fmt, args...) \
> do { \
> if (rtllib_debug_level & (level)) \
> - printk(KERN_DEBUG "rtllib: " fmt, ## args); \
> + pr_debug("rtllib: " fmt, ## args); \
> } while (0)
>
> #define RTLLIB_DEBUG_DATA(level, data, datalen) \
> do { \
> if ((rtllib_debug_level & (level)) == (level)) { \
> - printk(KERN_DEBUG "rtllib: %s()\n", __func__); \
> + pr_debug("rtllib: %s()\n", __func__); \
> print_hex_dump_bytes(KERN_DEBUG, DUMP_PREFIX_NONE, \
> data, datalen); \
> } \

We've made it slightly more tricky to turn on these debug statements.

I don't think that's a big problem. I don't think anyone cares about
them. They are just noise is my guess.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-04-14 10:41    [W:0.256 / U:2.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site