lkml.org 
[lkml]   [2015]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures
On Tue, Apr 14, 2015 at 10:23:16PM +0300, Eli Cohen wrote:
> On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote:
> > @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr)
> > static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id)
> > {
> > struct page *page;
> > - u64 addr;
> > + u64 addr = 0;
> > int err;
> > int nid = dev_to_node(&dev->pdev->dev);
> >
>
> I really don't see any reason why you need to set addr to 0. Can you
> please explain this?
> Other than that the patch is ok.

Sorry, I trid my best to explain it. But failed. I'm fine to remove it.
New patch will be submit. And I will insert a fix tag in it.

Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to
firmware)

thanks


\
 
 \ /
  Last update: 2015-04-15 05:21    [W:0.082 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site