Messages in this thread | | | From | Eli Cohen <> | Date | Tue, 14 Apr 2015 22:23:16 +0300 | Subject | Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures |
| |
On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote: > @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr) > static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id) > { > struct page *page; > - u64 addr; > + u64 addr = 0; > int err; > int nid = dev_to_node(&dev->pdev->dev); >
I really don't see any reason why you need to set addr to 0. Can you please explain this? Other than that the patch is ok.
| |