lkml.org 
[lkml]   [2015]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] More precise timestamps for nested writes
On Mon, Apr 13, 2015 at 09:38:01PM -0500, Suresh E. Warrier wrote:
> +static u64 *get_write_timestamp(struct ring_buffer_per_cpu *cpu_buffer,
> + unsigned long *flags)
> +{
> + if (rb_precise_nested_write_ts()) {
> + /*
> + * Ensure that we are not preempted until after we update
> + * the write timestamp.
> + */
> + local_irq_save(*flags);
> + return &cpu_buffer->last_stamp;

Yeah, ever hear about NMIs? This isn't going to work.

> + } else {
> + return &cpu_buffer->write_stamp;
> + }
> +}


\
 
 \ /
  Last update: 2015-04-14 19:21    [W:0.073 / U:7.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site