[lkml]   [2015]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper
On Tue, Apr 14, 2015 at 09:53:44AM -0700, Christoph Hellwig wrote:
> On Sat, Apr 11, 2015 at 09:04:02AM -0400, Jeff Layton wrote:
> > Yuck! How the heck do you clean up the mess if that happens? I guess
> > you're just stuck redoing the copy with normal READ/WRITE?
> >
> > Maybe we need to have the interface return a hard error in that
> > case and not try to give back any sort of offset?
> The NFSv4.2 COPY interface is a train wreck. At least for Linux I'd
> expect us to simply ignore it and only implement my new CLONE operation
> with sane semantics. That is unless someone can show some real life
> use case for the inter server copy, in which case we'll have to deal
> with that mess. But getting that one right at the VFS level will
> be a nightmare anyway.

Btw, in case someone cares about the NFS CLONE implementation here is
my prototype based on Anna's older COPY prototype. It's simple enough that
it might be worth adding to the copy_file_range patch set.

 \ /
  Last update: 2015-04-14 19:21    [W:0.064 / U:3.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site