Messages in this thread | | | Date | Tue, 14 Apr 2015 12:09:26 +0530 | Subject | Re: [PATCH v6 1/3] nand: pl353: Add basic driver for arm pl353 smc nand interface | From | punnaiah choudary kalluri <> |
| |
Hi Paul Bolle,
On Tue, Apr 14, 2015 at 12:27 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > On Mon, 2015-04-13 at 21:42 +0530, Punnaiah Choudary Kalluri wrote: > >> --- a/drivers/mtd/nand/Makefile >> +++ b/drivers/mtd/nand/Makefile > >> +obj-$(CONFIG_MTD_NAND_PL353) += pl353_nand.o > > (I think pl353_nand.o can be part of a module. If that's incorrect, you > can stop reading here.) > >> --- /dev/null >> +++ b/drivers/mtd/nand/pl353_nand.c > >> + * This program is free software; you can redistribute it and/or modify it under >> + * the terms of the GNU General Public License version 2 as published by the >> + * Free Software Foundation; either version 2 of the License, or (at your >> + * option) any later version. > > This states the license of this driver is GPL v2 or later. > >> +MODULE_LICENSE("GPL v2"); > > And according to include/linux/module.h this states the license is GPL > v2. So either the comment at the top of this file or the license ident > used in the MODULE_LICENSE() macro needs to change.
Thanks for the review. I will change the licence ident to "GPL".
I will wait some time for further functional comments on this driver before sending the next version of patches.
Regards, Punnaiah
> > Thanks, > > > Paul Bolle >
| |