Messages in this thread |  | | Date | Tue, 14 Apr 2015 18:46:22 +0200 | From | Nicolas Dichtel <> | Subject | Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink |
| |
Le 14/04/2015 18:30, Erez Shitrit a écrit : > On Tue, Apr 14, 2015 at 6:20 PM, Honggang Li <honli@redhat.com> wrote: [snip] > This will make parent interface to return 0 instead of its own ifindex. > I would suggest write something like that: > > + /* parent interface */ > + if (!test_bit(IPOIB_FLAG_SUBINTERFACE, &priv->flags)) > + return dev->ifindex; > + > + /* child/vlan interface */ > + if (!priv->parent) > + return -1; 'return 0' here.
|  |