Messages in this thread |  | | Date | Tue, 14 Apr 2015 11:40:13 -0400 | From | "ira.weiny" <> | Subject | Re: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib |
| |
On Tue, Apr 14, 2015 at 04:32:57PM +0200, Michael Wang wrote: > > > On 04/14/2015 04:18 PM, ira.weiny wrote: > [snip] > > > > /** > > - * cap_ib_cm_dev - Check if any port of device has the capability Infiniband > > - * Communication Manager. > > + * cap_ib_cm_any_port - Check if any port of the device has Infiniband > > + * Communication Manager (CM) support. > > * > > * @device: Device to be checked > > * > > - * Return 0 when all port of the device don't support Infiniband > > - * Communication Manager. > > + * Return 1 if any port of the device supports the IB CM. > > */ > > -static inline int cap_ib_cm_dev(struct ib_device *device) > > +static inline int cap_ib_cm_any_port(struct ib_device *device) > > { > > int i; > > I think we maybe able to get rid of this helper according to Sean's suggestion :-) > > We just need to check the port 1 of HCA see if it support ib cm, seems like > currently there is no case that port 1 support cm while others doesn't.
But that moves us in the wrong direction. If we later support port 2 without port 1 that code will be broken.
Ira
|  |