Messages in this thread |  | | Date | Tue, 14 Apr 2015 16:09:14 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware |
| |
On Tue, Apr 14, 2015 at 05:44:56PM +0800, Kweh, Hock Leong wrote: > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com> > > Introducing a kernel module to expose capsule loader interface > for user to upload capsule binaries. This module leverage the > request_firmware_direct_full_path() to obtain the binary at a > specific path input by user. > > Example method to load the capsule binary: > echo -n "/path/to/capsule/binary" > /sys/devices/platform/efi_capsule_loader/capsule_loader
Ick, why not just have the firmware file location present, and copy it to the sysfs file directly from userspace, instead of this two-step process?
> +/* > + * To remove this kernel module, just perform: > + * rmmod efi_capsule_loader.ko
This comment is not needed.
> + */ > +static void __exit efi_capsule_loader_exit(void) > +{ > + platform_device_unregister(efi_capsule_pdev);
This is not a platform device, don't abuse that interface please.
greg k-h
|  |