lkml.org 
[lkml]   [2015]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.
On Tue, Apr 14, 2015 at 02:14:14PM +0200, Thierry Reding wrote:
> On Tue, Mar 17, 2015 at 01:40:02PM +0100, Quentin Casasnovas wrote:
> > If one of these addresses point to a non-executable section, something is
> > seriously wrong since it either means the kernel will never fault from
> > there or it will not be able to jump to there. As both cases are serious
> > enough, we simply error out in these cases so the build fails and the
> > developper has to fix the issue.
> >
> > Signed-off-by: Quentin Casasnovas <quentin.casasnovas@oracle.com>
> > ---
> > scripts/mod/modpost.c | 141 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 141 insertions(+)
>
> This causes a bunch of mismatch warnings on 32-bit and 64-bit ARM
> because there are two additional sections, .text.fixup and
> .exception.text that store executable code. I've attached a patch
> to fix those, but feel free to squash that into the original commit
> if that's still possible.
>

Thanks Thierry!

Your patch looks good to me, though I was wondering if we should just add
.text.* in the TEXT_SECTIONS macro. Some architectures define
-ffunction-sections (parisc, score, metag and frv) so there are tons of
useless warnings on these.. It also means the current modpost sanity
checks don't run for those so it might even uncover some real mismatch ;)

Quentin


\
 
 \ /
  Last update: 2015-04-14 15:01    [W:2.403 / U:1.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site