[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v4 0/3] powerpc: powernv: Fastsleep workaround behavior
Fastsleep is one of the idle state which cpuidle subsystem currently
uses on power8 machines. In this state L2 cache is brought down to a
threshold voltage. Therefore when the core is in fastsleep, the
communication between L2 and L3 needs to be fenced. But there is a bug
in the current power8 chips surrounding this fencing.

OPAL provides a workaround which precludes the possibility of hitting
this bug. But running with this workaround applied causes checkstop
if any correctable error in L2 cache directory is detected. Hence OPAL
also provides a way to undo the workaround.

In the existing implementation, workaround is applied by the last thread
of the core entering fastsleep and undone by the first thread waking up.
But this has a performance cost. These OPAL calls account for roughly
4000 cycles everytime the core has to enter or wakeup from fastsleep.

This patchset introduces a sysfs attribute (fastsleep_workaround_state)
to choose the behavior of this workaround.

Patch 1/3 fixes cpu_online_cores_map which is used by Patch 3/3.
Patch 2/3 is a clean up patch. It moves all cpuidle related code into
a new file.
Patch 3/3 introduces the sysfs attribute to control fastsleep workaround

Changes in v4:
-Handling patch_instruction and OPAL call errors
-Sysfs attribute takes string ("dynamic" vs "applyonce") as input.
-Improved changelogs

Changes in v3:
-Kernel parameter changed to sysfs attribute

Changes in v2:
-Changed commit message to accurately describe the downside
of running workaround always applied.

Shreyas B. Prabhu (3):
powerpc: Fix cpu_online_cores_map to return only online threads mask
powerpc/powernv: Move cpuidle related code from setup.c to new file
powerpc/powernv: Introduce sysfs control for fastsleep workaround

arch/powerpc/include/asm/cputhreads.h | 13 +-
arch/powerpc/include/asm/opal-api.h | 7 +
arch/powerpc/include/asm/opal.h | 1 +
arch/powerpc/platforms/powernv/Makefile | 2 +-
arch/powerpc/platforms/powernv/idle.c | 323 +++++++++++++++++++++++++
arch/powerpc/platforms/powernv/opal-wrappers.S | 1 +
arch/powerpc/platforms/powernv/setup.c | 171 -------------
7 files changed, 341 insertions(+), 177 deletions(-)
create mode 100644 arch/powerpc/platforms/powernv/idle.c


 \ /
  Last update: 2015-04-14 04:41    [W:0.110 / U:3.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site