lkml.org 
[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/7] kallsyms header cleanup
Date
During review of an unrelated patchset, the question was asked why
module.h was included in code that wouldn't be a module and didn't do
anything with modules [1].

The reason is that it uses kallsyms defines, but kallsyms.h doesn't
include module.h, though it should because it uses MODULE_NAME_LEN.
The code in question also didn't include kallsyms.h but relied on
ftrace.h to pull it in. But ftrace.h no longer contains anything that
needs kallsyms.h, and continues to include it only because other code
expects it to.

This patchset is the start of cleaning all that up. It also adds
explicit kallsyms.h includes and removes module.h includes for obvious
cases in kernel/trace and lib/, where I happened to be working.

There are a bunch of other files that probably include module.h only
for kallsyms, but I haven't gone through them yet. I can either
resubmit this patchset after looking at all those, or can submit a
follow-on patchset to this one assuming this is best way to do it...

[1] https://lkml.org/lkml/2015/4/4/70

Changes from v1:
- added KSYM_SYMBOL_LEN patches for fnic and slub
- separated tracing changes into KSYM_SYMBOL_LEN-only module.h changes
- fixed up bogus lib change from previous patchset
- separate patch to remove unnecessary tracing kallsyms.h and module.h usage

The following changes since commit 3cfb2f7976a2f9cfe48eda4e6d7e4ce74fee09e3:

Merge tag 'pci-v4.0-fixes-3' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci (2015-04-09 10:17:44 -0700)

are available in the git repository at:


git://git.yoctoproject.org/linux-yocto-contrib.git tzanussi/kallsyms-header-cleanup-v2
http://git.yoctoproject.org/cgit.cgi//log/?h=kallsyms-v2

Tom Zanussi (7):
tracing: Remove kallsyms.h include from linux/ftrace.h
kallsyms: Add module.h include
tracing: Remove redundant module.h includes
lib: Remove redundant module.h includes
fnic: Remove redundant module.h includes
slub: Remove redundant module.h includes
tracing: Remove unnecessary kallsyms.h and module.h includes

drivers/scsi/fnic/fnic_trace.c | 1 -
include/linux/ftrace.h | 1 -
include/linux/kallsyms.h | 1 +
kernel/trace/trace.c | 2 --
kernel/trace/trace_branch.c | 2 --
kernel/trace/trace_export.c | 2 --
kernel/trace/trace_irqsoff.c | 2 --
kernel/trace/trace_kprobe.c | 1 +
kernel/trace/trace_output.c | 2 +-
kernel/trace/trace_sched_switch.c | 2 --
kernel/trace/trace_sched_wakeup.c | 2 --
kernel/trace/trace_stack.c | 2 --
kernel/trace/trace_syscalls.c | 2 +-
lib/vsprintf.c | 1 -
mm/slub.c | 1 -
15 files changed, 4 insertions(+), 20 deletions(-)

--
1.9.3



\
 
 \ /
  Last update: 2015-04-14 03:21    [W:0.066 / U:14.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site