lkml.org 
[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 00/21] staging: rtl8192e: Fix more checkpatch.pl warnings
Date
New cleanup patchset for rtl8192e. It fixes (mostly) checkpatch.pl warnings.
When applied, checkpatch.pl warning count drops to 34 (from 1111).
It should apply cleanly to staging-next/testing (c610f7f7) branches.

Series was smoke tested on rtl8192e card vs staging-next:
- Module load/unload
- Interface up/down

Most of changes are related to checkpatch.pl with the exception of
- bugfix - staging: rtl8192e: Fix DeviceID in rtl8192_pci_findadapter()
This is clearly (in my opinion) typo - I checked two rtl8192e cards from
different vendors and both had DeviceID == 0x8192.
- Removal of unimplemented/unused iwpriv handlers - they just give false sense
of hope to iwpriv user

Additional changes in v2:
- Fix (most) LONG_LINE warnings
- Replace memcpy() with custom macro - later __aligned(2) will be added to
structures (where possible) - I prefer not to do this change before I have
working hardware. Unfortunantely these cards are grumpy and refuse to enable
radio in PC mPCIe slot (even after soldering W_DISABLE override and using two
different antenna sets)
- Fix (most) remaining PREFER_PR_LEVEL warnings

Notes from v1:
This series of patches fixes another set of checkpatch.pl warnings.

Most of the patches are trivial, with the exception of #8, #7 and #5;
Driver logic should not be affected.
Some of the patches cause LONG_LINE warnings, but fix has to wait until
I do more driver refactorings (It's hard to keep line length when variable
names have 30 characters).

Mateusz Kulikowski (21):
staging: rtl8192e: Fix SPACE_BEFORE_TAB warnings
staging: rtl8192e: Copy comments from r819XE_phyreg.h to r8192E_phyreg.h
staging: rtl8192e: remove r819xE_phyreg.h
staging: rtl8192e: Fix SPACING errors
staging: rtl8192e: Remove bb tx gains from r8192_priv
staging: rtl8192e: Fix LINE_SPACING warning
staging: rtl8192e: Fix DEEP_INDENTATION warnings in rtllib_parse_info_param()
staging: rtl8192e: Fix DEEP_INDENTATION warnings in rtl_dm.c
staging: rtl8192e: Fix DeviceID in rtl8192_pci_findadapter()
staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned()
staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param()
staging: rtl8192e: replace memcmp() with ether_addr_equal_unaligned()
staging: rtl8192e: Fix PREFER_PR_LEVEL warnings
staging: rtl8192e: Fix LONG_LINE warnings
staging: rtl8192e: Fix LONG_LINE warnings - modify variables
staging: rtl8192e: Fix LONG_LING in rtllib_parse_info_param()
staging: rtl8192e: Fix LONG_LINE warnings (conditions)
staging: rtl8192e: fix LONG_LINE warnings - replace ?: expressions
staging: rtl8192e: Fix LONG_LINE in rtllib_parse_mife_generic()
staging: rtl8192e: Fix LONG_LINE in simplify rtl8192_process_phyinfo()
staging: rtl8192e: Remove unimplemented iwpriv handlers

drivers/staging/rtl8192e/dot11d.h | 4 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 144 +-
.../staging/rtl8192e/rtl8192e/r8192E_firmware.c | 42 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 51 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 1496 ++++++++++---------
drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 908 ------------
drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 53 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 10 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 21 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 1546 ++++++++------------
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 9 +
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 89 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 3 +-
drivers/staging/rtl8192e/rtl819x_TSProc.c | 21 +-
drivers/staging/rtl8192e/rtllib.h | 8 +-
drivers/staging/rtl8192e/rtllib_crypt.c | 17 +-
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 77 +-
drivers/staging/rtl8192e/rtllib_debug.h | 3 +-
drivers/staging/rtl8192e/rtllib_rx.c | 797 +++++-----
drivers/staging/rtl8192e/rtllib_softmac.c | 360 ++---
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 5 +-
drivers/staging/rtl8192e/rtllib_tx.c | 87 +-
drivers/staging/rtl8192e/rtllib_wx.c | 4 +-
25 files changed, 2289 insertions(+), 3480 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h

--
1.8.4.1



\
 
 \ /
  Last update: 2015-04-14 00:21    [W:0.162 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site