lkml.org 
[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH try #3] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline
On Mon, 13 Apr 2015 14:28:49 -0400 Jarod Wilson <jarod@redhat.com> wrote:

> > Well, it's 8 MB at least because of kmalloc and more when it starts
> > to vmalloc, so either you increase but keep the limit, or allow
> > to pin semi-arbitrary amount of kernel memory IF you want to stay
> > with seqfile. My patch requires just 1 page plus whatever g_u_p
> > requires.
>
> Okay, I've tested this out some. Its definitely more user-friendly than
> having to require a boot param, and as a bonus, its even more
> memory-efficient. Yes, its a bit fugly, but such is life sometimes...
>
> Though I do wonder if this should perhaps be a helper in mm/util.c like
> get_cmdline, maybe replacing get_cmdline or adding an alternative that
> gives you everything, rather than an arbitrarily limited length. I only
> see one other place actually using get_cmdline so far.
>
> Tested-by: Jarod Wilson <jarod@redhat.com>
> Acked-by: Jarod Wilson <jarod@redhat.com>

Thanks, I'll take another look after the 4.0 merge flurry.


\
 
 \ /
  Last update: 2015-04-13 23:01    [W:0.045 / U:23.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site