lkml.org 
[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm
On Mon, Apr 13, 2015 at 06:40:35PM +0000, Hefty, Sean wrote:
> > > - if (rdma_node_get_transport(ib_device->node_type) !=
> > RDMA_TRANSPORT_IB)
> > > - return;
> > > + int count = 0;
> >
> > I'm ok with this as an intermediate patch but going forward if we are
> > going to
> > have calls like
> >
> > static inline int cap_ib_cm_dev(struct ib_device *device)
>
> I would rather keep everything to checking per port, not per device.
> Specifically, because we have code that does this:

Argee.

I asked Michael for it and stand by it, the property is per-port, not
per device. Having the per-device tests just muddles the logic, look
at the trouble Sean notices in #10 when we are now forced to think of
things clearly.

Jason


\
 
 \ /
  Last update: 2015-04-13 22:01    [W:0.133 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site