Messages in this thread |  | | Date | Mon, 13 Apr 2015 13:29:30 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm |
| |
On Mon, Apr 13, 2015 at 06:40:35PM +0000, Hefty, Sean wrote: > > > - if (rdma_node_get_transport(ib_device->node_type) != > > RDMA_TRANSPORT_IB) > > > - return; > > > + int count = 0; > > > > I'm ok with this as an intermediate patch but going forward if we are > > going to > > have calls like > > > > static inline int cap_ib_cm_dev(struct ib_device *device) > > I would rather keep everything to checking per port, not per device. > Specifically, because we have code that does this:
Argee.
I asked Michael for it and stand by it, the property is per-port, not per device. Having the per-device tests just muddles the logic, look at the trouble Sean notices in #10 when we are now forced to think of things clearly.
Jason
|  |