[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subjectpowerpc: Dead code in commit bdc728a849a7
Hi Daniel,

your commit bdc728a849a7 ("powerpc: move find_and_init_phbs() to pSeries
specific code") in today's Linux next tree moves a function into the
pSeries specific setup.c file. I noticed it because I'm running an
automated bot on top of linux-next which looks for variability-related
defects with undertaker-checkpatch[0].

Inside the function, there is an #ifdef block which depends on
CONFIG_PPC32 to be set. However, the file at
arch/powerpc/platforms/pseries/setup.c will only be built if
CONFIG_PPC_PSERIES is enabled[1], which through its Kconfig dependencies
can only be selected if CONFIG_PPC64 is enabled[2]. As CONFIG_PPC32 and
CONFIG_PPC64 are mutually exclusive, the #ifdef can never evaluate to
true, and the corresponding code is dead.

Should I send a patch which removes the #ifdef and the dead code or
would you prefer to do this yourself?

Best regards,


[1] arch/powerpc/platforms/Makefile, line 18
[2] arch/powerpc/platforms/pseries/Kconfig, line 2

 \ /
  Last update: 2015-04-13 21:01    [W:0.041 / U:6.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site