lkml.org 
[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: of-serial: Remove device_type = "serial" registration
[ + Arnd ]

Hi Michal,

On 04/13/2015 10:35 AM, Michal Simek wrote:
> Do not probe all serial drivers by of_serial.c which are using
> device_type = "serial"; property. Only drivers which have valid
> compatible strings listed in the driver should be probed.

What does this fix?
Is there some kind of probe problem you're trying to address?
Are you trying to silence the error message?

> When PORT_UNKNOWN probe will fail anyway.

Ok, but doesn't device_attach() just continue to try to match other
drivers on the platform bus?

Regards,
Peter Hurley

> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> CC: <stable@vger.kernel.org>
> ---
>
> drivers/tty/serial/of_serial.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
> index 33fb94f78967..0a52c8b55a5f 100644
> --- a/drivers/tty/serial/of_serial.c
> +++ b/drivers/tty/serial/of_serial.c
> @@ -344,7 +344,6 @@ static struct of_device_id of_platform_serial_table[] = {
> { .compatible = "ibm,qpace-nwp-serial",
> .data = (void *)PORT_NWPSERIAL, },
> #endif
> - { .type = "serial", .data = (void *)PORT_UNKNOWN, },
> { /* end of list */ },
> };
>
>



\
 
 \ /
  Last update: 2015-04-13 18:21    [W:0.102 / U:11.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site