lkml.org 
[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] drm/msm: match wait_for_completion_timeout return type
On Sat, Apr 11, 2015 at 03:10:36PM +0200, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch assigns the return value of wait_for_completion_timeout to an
> appropriately typed and named variable.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> This was compile tested with qcom_defconfig +
> CONFIG_DRM=m (implies CONFIG_DRM_MSM=m)
>
> Patch is against 4.0-rc7 (localversion-next is -next-20150410)
>
> drivers/gpu/drm/msm/edp/edp_ctrl.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> index 0ec5abd..831acd6 100644
> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> @@ -1018,7 +1018,7 @@ static void edp_ctrl_off_worker(struct work_struct *work)
> {
> struct edp_ctrl *ctrl = container_of(
> work, struct edp_ctrl, off_work);
> - int ret;
> + unsigned long time_left;
>
> mutex_lock(&ctrl->dev_mutex);
>
> @@ -1030,11 +1030,11 @@ static void edp_ctrl_off_worker(struct work_struct *work)
> reinit_completion(&ctrl->idle_comp);
> edp_state_ctrl(ctrl, EDP_STATE_CTRL_PUSH_IDLE);
>
> - ret = wait_for_completion_timeout(&ctrl->idle_comp,
> + time_left = wait_for_completion_timeout(&ctrl->idle_comp,
> msecs_to_jiffies(500));
> - if (ret <= 0)
> - DBG("%s: idle pattern timedout, %d\n",
> - __func__, ret);
> + if (time_left <= 0)

Given that time_left is unsigned now, why bother with the "< 0"?

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-04-13 16:21    [W:0.233 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site