lkml.org 
[lkml]   [2015]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable.
From
Date
Hi, jirka

> On Apr 10, 2015, at 6:31 PM, Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Thu, Apr 09, 2015 at 11:26:31PM +0900, Taeung Song wrote:
>> This patch consists of adding functions
>> which get, set or remove a specific config variable.
>> For the syntax examples,
>>
>> perf config [options] [section.subkey[=value]]
>>
>> display all perf config with default values
>> # perf config
>> or
>> # perf config -a | --all
>
> so this is ^^^ what the previous patch does right?
>
>>
>> display a specific key(section.subkey) and value
>> # perf config report.queue
>>
>> set a specific key and value
>> # perf config report.queue=100M
>>
>> remove a specific key
>> # perf config -r | --remove report.queue
>
> haven't checked the code but:
>
> [jolsa@krava perf]$ ./perf config krava=true
> The config variable does not contain a section: krava=true[jolsa@krava perf]$
>
> missing '\n'
>
> we can set anything now:
> [jolsa@krava perf]$ ./perf config krava.krava=true
>
> the restriction for only known keys would need similar stuff like
> for the '-a' option I asked in the previous email right?
>

Thanks for your review.
I sent a couple of patch again.

1. I modified a commit message of second patch to remove comment about ‘-a’, ‘—all’ option.
2. I added ‘\n’ character when printing some error messages.
3. I added ‘Error: Unknown argument’ message.

But I thought that displaying current config with all possible keys and their default values,
and the restriction for only known keys depending on information of all perf configuration
can be included in next patch.
Would you mind ?

Thanks,
Taeung

\
 
 \ /
  Last update: 2015-04-12 17:21    [W:0.077 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site