lkml.org 
[lkml]   [2015]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] livepatch: Fix the bug if the function name is larger than KSYM_NAME_LEN-1
Date
For now, the kallsyms will only store the first (KSYM_NAME_LEN-1). The
kallsyms name is same for the function which first (KSYM_NAME_LEN-1) is
same, but the rest is not.

Then function will never be patched, although function name and address
are provided both. The reason caused this bug is livepatch cannt
recognize the function name.

Now, livepatch will verify the function name with first (KSYM_NAME_LEN-1)
and address, if provided. Once they are matched, we can confirm that the
patched function is found.

Signed-off-by: Minfei Huang <minfei.huang@hotmail.com>
---
kernel/livepatch/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index ff42c29..eed719d 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -210,7 +210,7 @@ static int klp_verify_vmlinux_callback(void *data, const char *name,
struct klp_verify_args *args = data;

if (!mod &&
- !strcmp(args->name, name) &&
+ !strncmp(args->name, name, KSYM_NAME_LEN-1) &&
args->addr == addr)
return 1;

@@ -226,7 +226,7 @@ static int klp_verify_module_callback(void *data, const char *name,
return 0;

if (!strcmp(args->objname, mod->name) &&
- !strcmp(args->name, name) &&
+ !strncmp(args->name, name, KSYM_NAME_LEN-1) &&
args->addr == addr)
return 1;

--
2.2.2


\
 
 \ /
  Last update: 2015-04-12 16:01    [W:0.089 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site