[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW
On 04/09/2015 11:19 PM, Doug Ledford wrote:
>> I've written this before: The mess here is that it is too hard to know
>> what the call sites are actually checking for when it is some baroque
>> conditional.
> The two goals: being specific about what the test is returning and
> minimizing the bitmap footprint; are not necessarily opposed. One can
> do both at the same time.

This could be internal reforming after the cap_XX() stuff works for core
layer, at that time we don't need to touch core layer anymore, just
introducing this bitmap stuff in verb layer, replacing the implementation
of these helpers with the bitmap check, and following the semantic (description).

Michael Wang


 \ /
  Last update: 2015-04-10 10:21    [W:0.119 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site