Messages in this thread |  | | From | Andy Lutomirski <> | Date | Fri, 10 Apr 2015 14:59:19 -0700 | Subject | Re: [PATCH v3 1/2] x86_64,signal: Fix SS handling for signals delivered to 64-bit programs |
| |
On Fri, Mar 20, 2015 at 7:47 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote: > On Fri, Mar 20, 2015 at 03:07:38PM +0100, Oleg Nesterov wrote: >> >> Another downside (to me) is that this special case can help, but only >> "by accident". >> >> For example, criu has ->ss = 0, but it was not initialized explicitly. >> >> But as I said, I won't argue. > > OK, after talking to Pavel -- it's fine to require new criu version > for new kernels, thus lets leave kernel pure without this special > hack, moreover now we have a fix from Oleg merged into criu so we > should be safe. Thanks a lot for all comments!
As long as you're doing that, any chance you could remove CPREG1(gs) and CPREG1(fs) as well? They haven't had any effect since 2.5.something_very_old, and the kernel might want to reuse those sigcontext slots some day.
--Andy
|  |