lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] x86: Add support for rd/wr fs/gs base
> I think all of this stems from unfortunate naming.  DEBUG_STACK isn't
> one stack -- it's a debug stack *array*. The IST shift mechanism
> means that we can use different entries in that array as our stacks
> depending on how deeply nested we are.

I still think it's a terrible idea.

> > Just handling it in the code is simple enough.
>
> It seems to account for over half the asm diff. I'm talking about the
> addition of approximately two lines of C and the removal of a huge
> chunk of the asm diff.

It's just adding offsets to the stack code. Nothing complicated.
It's also straight forward code. Far more preferable than your magic
overlapping stacks.

-Andi
--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2015-04-10 23:21    [W:0.084 / U:3.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site