lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 0/3] Add ktd2692 Flash LED driver using LED Flash class
Hi Varka,

On 2015년 04월 10일 15:59, Varka Bhadram wrote:
> On 04/10/2015 12:15 PM, Ingi Kim wrote:
>
>> This patch adds ktd2692 Flash LED driver with LED Flash class
>>
>> Change in v6:
>> - Change goto label to if-else
>> - Change DT binding style for LED device binding
>>
>> Change in v5:
>> - Clean up the code
>> - Fix help message of Kconfig
>> - Fix issue related with regulator and mutex usage
>> - Remove tab spaces in bindings
>>
>> Change in v4:
>> - Clean up the code
>> - Modify binding documentation of ktd2692
>>
>> Change in v3:
>> - Clean up the code
>> - Add aux gpio pin to control Flash LED
>>
>> Change in v2:
>> - Introduction of LED Flash class as Jacek's comment
>> - Supplement of binding documentation
>> - Rename gpio control pin and remove unused pin
>> - Add regulator for the Flash LED
>>
>> Ingi Kim (3):
>> of: Add vendor prefix for Kinetic technologies
>> leds: ktd2692: add device tree bindings for ktd2692
>> leds: Add ktd2692 flash LED driver
>>
>> .../devicetree/bindings/leds/leds-ktd2692.txt | 40 ++
>> .../devicetree/bindings/vendor-prefixes.txt | 1 +
>> drivers/leds/Kconfig | 9 +
>> drivers/leds/Makefile | 1 +
>> drivers/leds/leds-ktd2692.c | 408 +++++++++++++++++++++
>> 5 files changed, 459 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>> create mode 100644 drivers/leds/leds-ktd2692.c
>>
> Run checkpatch.pl with --strict option on this series..
>
> ./scripts/checkpatch.pl --strict 000*
>
> Reported "CHECK: Alignment should match open parenthesis"..
>

I used checkpatch.pl script but I wasn't aware of this option.
It reveals my mistakes more :)

Thanks


\
 
 \ /
  Last update: 2015-04-10 09:41    [W:0.374 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site