Messages in this thread Patch in this message | | | Date | Fri, 10 Apr 2015 10:24:59 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH v2 05/12] ARM: dts: apq8064: Add SATA controller support. |
| |
On 04/10/15 05:34, Srinivas Kandagatla wrote: > This patch adds AHCI based SATA controller support to APQ8064. > Tested on IFC6410 board. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 ++++++++ > arch/arm/boot/dts/qcom-apq8064.dtsi | 35 ++++++++++++++++++++++++++++++ > 2 files changed, 44 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > index 122bf34..c9c9c5e 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > @@ -116,6 +116,15 @@ > }; > }; > > + sata_phy0: sata-phy@1b400000{
Space before '{' please.
> + status = "okay"; > + }; > + > + sata0: sata@29000000 { > + status = "okay"; > + target-supply = <&pm8921_s4>; > + }; > + > /* OTG */ > usb1_phy: phy@12500000 { > status = "okay"; > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index 5aac9a5..56cc65e 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -379,6 +379,41 @@ > usb-phy = <&usb4_phy>; > }; > > + sata_phy0: sata-phy@1b400000{
Space before '{' please. Also I wonder if it should just be called phy@1b400000 because phy is more standard than sata-phy.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |