Messages in this thread |  | | Subject | Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW | From | Doug Ledford <> | Date | Fri, 10 Apr 2015 12:48:32 -0400 |
| |
On Fri, 2015-04-10 at 09:46 +0200, Michael Wang wrote: > On 04/09/2015 11:19 PM, Doug Ledford wrote: > [snip] > >> > >> I've written this before: The mess here is that it is too hard to know > >> what the call sites are actually checking for when it is some baroque > >> conditional. > > > > The two goals: being specific about what the test is returning and > > minimizing the bitmap footprint; are not necessarily opposed. One can > > do both at the same time. > > This could be internal reforming after the cap_XX() stuff works for core > layer, at that time we don't need to touch core layer anymore, just > introducing this bitmap stuff in verb layer, replacing the implementation > of these helpers with the bitmap check, and following the semantic (description).
Agreed.
-- Doug Ledford <dledford@redhat.com> GPG KeyID: 0E572FDD
[unhandled content-type:application/pgp-signature] |  |