[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/4] tracing: Remove redundant module.h includes
On Fri, 10 Apr 2015 11:05:02 -0500
Tom Zanussi <> wrote:

> kallsyms.h now includes module.h, so remove module.h includes that
> were apparently there only to satisfy kallsyms use of MODULE_NAME_LEN.

Only remove it for those that need it for MODULE_NAME_LEN because it
was used in KSYM_SYMBOL_LEN. But not the rest. Lots of these files use
module code directly. Now you made it require kallsyms.h to get to that
code. If for some reason we no longer need kallsyms.h, or that
kallsyms.h no longer needs module.h, these files will not build.

If code uses module code, it must include module.h.

So NACK for this patch.

To see what needs module.h, before reverting this patch, remove the
module.h from kallsyms.h, and also remove the MODULE_NAME_LEN from it as
well. Compile all the tracing code, and see what does not build. Those
files will be the ones that you need to add back the module.h to.

-- Steve

 \ /
  Last update: 2015-04-10 19:01    [W:0.078 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site