lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] MIPS: Fix HIGHMEM crash in __update_cache().
Ralf,

I came to think that also non-executable mappings for highmem pages could reach the flushing code in __update_cache() and trigger an OOPS.

Until the highmem patches are merged we should block highmem pages in __update_cache(). Could you add this to the patch ?

Sent from my iPhone

> 10 apr 2015 kl. 15:47 skrev Ralf Baechle <ralf@linux-mips.org>:
>
>> On Fri, Apr 10, 2015 at 03:21:24PM +0200, Lars Persson wrote:
>>
>> Commit 8b5fe5e54b47 ("MIPS: Fix race condition in lazy cache flushing.")
>> triggered NULL pointer dereferences on systems with HIGHMEM.
>>
>> The problem was caused by not clearing the PG_dcache_dirty flag in
>> flush_icache_page() and thus we enter __update_cache() that lacks
>> support for HIGHMEM.
>
> Thanks, I've folded this patch into the original 8b5fe5e54b47 commit.
>
> Ralf


\
 
 \ /
  Last update: 2015-04-10 17:01    [W:0.067 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site