lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19 09/75] ASoC: tas5086: Fix wrong value references for boolean kctl
    Date
    3.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 4c523ef61160b7d478371ddc9f48c8ce0a00d675 upstream.

    The correct values referred by a boolean control are
    value.integer.value[], not value.enumerated.item[].
    The former is long while the latter is int, so it's even incompatible
    on 64bit architectures.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/codecs/tas5086.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/soc/codecs/tas5086.c
    +++ b/sound/soc/codecs/tas5086.c
    @@ -281,7 +281,7 @@ static int tas5086_get_deemph(struct snd
    struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
    struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);

    - ucontrol->value.enumerated.item[0] = priv->deemph;
    + ucontrol->value.integer.value[0] = priv->deemph;

    return 0;
    }
    @@ -292,7 +292,7 @@ static int tas5086_put_deemph(struct snd
    struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
    struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);

    - priv->deemph = ucontrol->value.enumerated.item[0];
    + priv->deemph = ucontrol->value.integer.value[0];

    return tas5086_set_deemph(codec);
    }



    \
     
     \ /
      Last update: 2015-04-10 16:21    [W:4.032 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site