lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19 75/75] mfd: kempld-core: Fix callback return value check
    Date
    3.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ameya Palande <2ameya@gmail.com>

    commit c8648508ebfc597058d2cd00b6c539110264a167 upstream.

    On success, callback function returns 0. So invert the if condition
    check so that we can break out of loop.

    Signed-off-by: Ameya Palande <2ameya@gmail.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mfd/kempld-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mfd/kempld-core.c
    +++ b/drivers/mfd/kempld-core.c
    @@ -739,7 +739,7 @@ static int __init kempld_init(void)
    for (id = kempld_dmi_table;
    id->matches[0].slot != DMI_NONE; id++)
    if (strstr(id->ident, force_device_id))
    - if (id->callback && id->callback(id))
    + if (id->callback && !id->callback(id))
    break;
    if (id->matches[0].slot == DMI_NONE)
    return -ENODEV;



    \
     
     \ /
      Last update: 2015-04-10 16:01    [W:4.107 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site