lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19 22/75] regmap: regcache-rbtree: Fix present bitmap resize
    Date
    3.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lars-Peter Clausen <lars@metafoo.de>

    commit 328f494d95aac8bd4896aea2328bc281053bcb71 upstream.

    When inserting a new register into a block at the lower end the present
    bitmap is currently shifted into the wrong direction. The effect of this is
    that the bitmap becomes corrupted and registers which are present might be
    reported as not present and vice versa.

    Fix this by shifting left rather than right.

    Fixes: 472fdec7380c("regmap: rbtree: Reduce number of nodes, take 2")
    Reported-by: Daniel Baluta <daniel.baluta@gmail.com>
    Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/base/regmap/regcache-rbtree.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/base/regmap/regcache-rbtree.c
    +++ b/drivers/base/regmap/regcache-rbtree.c
    @@ -307,7 +307,7 @@ static int regcache_rbtree_insert_to_blo
    if (pos == 0) {
    memmove(blk + offset * map->cache_word_size,
    blk, rbnode->blklen * map->cache_word_size);
    - bitmap_shift_right(present, present, offset, blklen);
    + bitmap_shift_left(present, present, offset, blklen);
    }

    /* update the rbnode block, its size and the base register */



    \
     
     \ /
      Last update: 2015-04-10 16:01    [W:4.098 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site