lkml.org 
[lkml]   [2015]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Staging: sm750fb: fix brace coding style issues
On Fri, Apr 10, 2015 at 12:12:15AM +0200, Robin Karlsson wrote:
> This is a patch to sm750fb that fixes brace coding style errors and warnings found by checkpatch.pl
Try to limit this commit message to 72 char.

You should usually use scripts/get_maintainer.pl to see where to send
the mail.
>
> Signed-off-by: Robin Karlsson <s.r.karlsson@gmail.com>
> ---
<snip>
> @@ -217,19 +214,17 @@ void hw_cursor_setData2(struct lynx_cursor * cursor,
> else
> opr = mask & color;
>
> - for(j=0;j<8;j++)
> - {
> + for(j=0;j<8;j++) {
>
> - if(opr & (0x80 >> j))
> - { //use fg color,id = 2
> + if(opr & (0x80 >> j)) { //use fg color,id = 2
this is introducing new checkpatch error.
Error: trailing statements should be on next line

regards
sudip
> data |= 2 << (j*2);


\
 
 \ /
  Last update: 2015-04-10 08:21    [W:0.079 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site