lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log
On Tue, 31 Mar 2015 20:18:28 -0700
Joe Perches <joe@perches.com> wrote:

> Neither __func__ or __FILE__ is really useful here.
> The message is already specific enough without it.
>
> If anything, it'd probably be better to add
>
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Seems reasonable given that pr_fmt is widely
used elsewhere.

I don't like too much the need to have one define for
each file, but it's the way it works :-/

--

Best regards,

Alessandro Zummo - CEO,
Tower Technologies - Torino, Italy

http://www.towertech.it



\
 
 \ /
  Last update: 2015-04-01 09:41    [W:0.092 / U:2.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site