Messages in this thread | | | Date | Wed, 1 Apr 2015 20:46:25 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] lfsr: a simple binary Galois linear feedback shift register |
| |
On Wed, Apr 01, 2015 at 06:46:32PM +0200, Peter Zijlstra wrote: > > > > Since it is used in conjunction with hashing, it is possible that hashing > > can produce a value of 0. Do we really want to have a warning for that? > > Alternatively, we can pass in some flag to decide if a warning should be > > issued. > > So if we present it as generic code we cannot assume what it'll be used > for. The only thing we know is that it should never be 0, so warn for it > and let the user deal with it.
Also while i like the lfsr probe i feel we should listen to my wiser self and go with a simpler linear probe first. Only of we find prpblems with that should we look into different things.
| |