lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0
From
On Mon, Mar 30, 2015 at 4:46 PM, Joe Perches <joe@perches.com> wrote:

> * try_wait_for_completion - try to decrement a completion without blocking
> * @x: completion structure
> *
> - * Return: 0 if a decrement cannot be done without blocking
> - * 1 if a decrement succeeded.
> + * Return: true if a decrement cannot be done without blocking
> + * false if a decrement succeeded.

Hi Joe,

The boolean logic was reversed in this comment. The function should be
returning false if a decrement cannot be done without blocking, and
true if a decrement succeeded.


\
 
 \ /
  Last update: 2015-04-01 07:41    [W:0.318 / U:7.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site