lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] irqchip: renesas-intc-irqpin: Add optional functional clock to bindings
From
Hi Sergei,

On Wed, Mar 18, 2015 at 6:55 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>> ---
>> a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
>> +++
>> b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt

>> +Example
>> +-------
>> +
>> + irqpin1: irqpin@e6900004 {
>
>
> The node name should be "interrupt-controller@e6900004".

Will fix (also the dtsi).

>> + compatible = "renesas,intc-irqpin-r8a7740",
>> + "renesas,intc-irqpin";
>> + #interrupt-cells = <2>;
>> + interrupt-controller;
>> + reg = <0xe6900004 4>,
>> + <0xe6900014 4>,
>> + <0xe6900024 1>,
>> + <0xe6900044 1>,
>> + <0xe6900064 1>;
>> + interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH
>> + 0 149 IRQ_TYPE_LEVEL_HIGH
>> + 0 149 IRQ_TYPE_LEVEL_HIGH
>> + 0 149 IRQ_TYPE_LEVEL_HIGH
>> + 0 149 IRQ_TYPE_LEVEL_HIGH
>> + 0 149 IRQ_TYPE_LEVEL_HIGH
>> + 0 149 IRQ_TYPE_LEVEL_HIGH
>> + 0 149 IRQ_TYPE_LEVEL_HIGH>;
>
> Hm, 8 similar interrupts?

Yes, all interrupts are wired to the same parent on r8a7740.
However, the binding docs indeed don't mention that there should be
one entry per interrupt handled by the module. I'll fix that, too.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2015-04-01 11:41    [W:0.094 / U:1.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site