lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] Staging: rtl8192 Clean up function definition
On Tue, Mar 31, 2015 at 01:25:02PM -0600, Eddie Kovsky wrote:
> On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote:
> > On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote:
> > > Change function definition to static, move the function further up in
> > > the file, and delete the function prototype.
> > >
> > > This fixes the following warning generated by sparse:
> > >
> > > drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol
> > > 'rtl8192_update_ratr_table' was not declared. Should it be static?
> > >
> >
> > Someone already fixed the warning earlier but this this is still a nice
> > patch to have.
> >
> > regards,
> > dan carpenter
> Dan
>
> I sent in the patch last week to fix this warning. You had asked me to
> clean up the function by removing the prototype instead. Greg had
> already sent me a message saying he picked up that patch. I waited a few
> cycles, but I still haven't seen my patch show up in yesterday's (or
> today's) next.

Greg has a testing tree where patches sit for a bit before they hit
linux-next.

>
> I assume my original patch got dropped waiting on this one?

He would have emailed you if your patch was dropped.

But maybe hold off and resend with an updated patch when it hits.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-04-01 10:21    [W:0.057 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site