Messages in this thread | | | Date | Mon, 09 Mar 2015 17:37:40 -0600 | From | Shuah Khan <> | Subject | Re: [PATCH v3 6/7] selftests/mqueue: Use implicit rules |
| |
On 03/04/2015 03:41 AM, Michael Ellerman wrote: > There's no need to open-code the build rules, use the implicit ones. > > This has the nice side effect of enabling cross compilation. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > --- > tools/testing/selftests/mqueue/Makefile | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile > index 6ca7261b55dc..ed85a1d7ee36 100644 > --- a/tools/testing/selftests/mqueue/Makefile > +++ b/tools/testing/selftests/mqueue/Makefile > @@ -1,6 +1,11 @@ > -all: > - gcc -O2 mq_open_tests.c -o mq_open_tests -lrt > - gcc -O2 -o mq_perf_tests mq_perf_tests.c -lrt -lpthread -lpopt
Nack. I can't take this one either. This breaks make kselftest run. mqueue fails to build.
-- Shuah
-- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |