lkml.org 
[lkml]   [2015]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID
    On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
    <sudipm.mukherjee@gmail.com> wrote:
    > check if it is already defined before defining SM750LE_REVISION_ID
    > again and at the same time mention correct data type.
    >
    > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
    > ---
    >
    > v2: removed the redundant cast in sm750_hw.c
    >
    > drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
    > drivers/staging/sm750fb/sm750_hw.c | 2 +-
    > 2 files changed, 4 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h
    > index 1c78875..d761b72 100644
    > --- a/drivers/staging/sm750fb/ddk750_chip.h
    > +++ b/drivers/staging/sm750fb/ddk750_chip.h
    > @@ -1,7 +1,9 @@
    > #ifndef DDK750_CHIP_H__
    > #define DDK750_CHIP_H__
    > #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */
    > -#define SM750LE_REVISION_ID (char)0xfe
    > +#ifndef SM750LE_REVISION_ID
    > +#define SM750LE_REVISION_ID ((unsigned char)0xfe)

    BTW who is defining this somewhere else ?

    Cheers,
    --Prabhakar Lad


    \
     
     \ /
      Last update: 2015-03-09 09:01    [W:2.982 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site