Messages in this thread | | | Date | Mon, 9 Mar 2015 11:40:11 -0700 | Subject | Re: [PATCH v2 1/1] serial: 8250_dw: Fix get_mctrl behaviour | From | Dmitry Torokhov <> |
| |
On Thu, Feb 26, 2015 at 4:35 PM, Jonathan Richardson <jonathar@broadcom.com> wrote: > @@ -334,6 +342,30 @@ static int dw8250_probe_of(struct uart_port *p, > if (id >= 0) > p->line = id; > > + if (of_property_read_bool(np, "dcd-override")) { > + /* Always report DCD as active */ > + data->msr_mask_on |= UART_MSR_DCD; > + data->msr_mask_off |= UART_MSR_DDCD; > + } > + > + if (of_property_read_bool(np, "dsr-override")) { > + /* Always report DSR as active */ > + data->msr_mask_on |= UART_MSR_DSR; > + data->msr_mask_off |= UART_MSR_DDSR; > + } > + > + if (of_property_read_bool(np, "cts-override")) { > + /* Always report DSR as active */ > + data->msr_mask_on |= UART_MSR_DSR; > + data->msr_mask_off |= UART_MSR_DDSR; > + } > + > + if (of_property_read_bool(np, "ri-override")) { > + /* Always report Ring indicator as inactive */ > + data->msr_mask_off |= UART_MSR_RI; > + data->msr_mask_off |= UART_MSR_TERI;
This looks like a typo. Should the 1st line be data->msr_mask_on by any chance?
Thanks, Dmitry
| |