Messages in this thread | | | Date | Mon, 9 Mar 2015 14:53:37 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print |
| |
On Mon, Mar 09, 2015 at 01:05:03PM +0530, Sudip Mukherjee wrote: > mention correct format specifier while printing. > fixes all the build warnings about incorrect argument type while > printing. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > > V2: Giedrius commented resource_size_t can be either u64 or u32 > depending on if CONFIG_PHYS_ADDR_T_64BIT. based on his comments i > should have kept the datatype as resource_size_t and used %pa as the > format specifier. But since this is a framebuffer device and it > should follow what the framebuffer layer is suggesting in > struct fb_fix_screeninfo at smem_start and mmio_start. > adding Tomi for his comments.
This should all have gone into the changelog because it changes how the code works.
regards, dan carpenter
| |