Messages in this thread | | | Subject | Re: [PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style | From | Joe Perches <> | Date | Sun, 08 Mar 2015 21:48:16 -0700 |
| |
On Mon, 2015-03-09 at 12:42 +0800, Yakir Yang wrote: > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c [] > @@ -900,10 +900,10 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep, > { > unsigned res_idx, i; > u8 val, msec; > - const struct dw_hdmi_mpll_config *mpll_config = > - hdmi->plat_data->mpll_cfg; > - const struct dw_hdmi_curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr; > - const struct dw_hdmi_sym_term *sym_term = hdmi->plat_data->sym_term; > + const struct dw_hdmi_plat_data *plat_data = hdmi->plat_data; > + const struct dw_hdmi_mpll_config *mpll_config = plat_data->mpll_cfg; > + const struct dw_hdmi_curr_ctrl *curr_ctrl = plat_data->cur_ctr; > + const struct dw_hdmi_sym_term *sym_term = plat_data->sym_term; > > if (prep) > return -EINVAL;
Shouldn't all of these be static?
| |