lkml.org 
[lkml]   [2015]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] serial: 8250: fix a sparse warning
    On 2015/3/9 16:22, Greg KH wrote:
    > On Mon, Mar 09, 2015 at 03:42:30PM +0800, Zhang Zhen wrote:
    >> drivers/tty/serial/8250/8250_core.c: In function ‘serial8250_console_write’:
    >> drivers/tty/serial/8250/8250_core.c:3244: warning: ‘flags’ may be used u
    >> unitialized in this function
    >>
    >> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
    >> ---
    >> drivers/tty/serial/8250/8250_core.c | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
    >> index deae122..50702e2 100644
    >> --- a/drivers/tty/serial/8250/8250_core.c
    >> +++ b/drivers/tty/serial/8250/8250_core.c
    >> @@ -3241,7 +3241,7 @@ serial8250_console_write(struct console *co, const char *s, unsigned int count)
    >> {
    >> struct uart_8250_port *up = &serial8250_ports[co->index];
    >> struct uart_port *port = &up->port;
    >> - unsigned long flags;
    >> + unsigned long flags = 0;
    >> unsigned int ier;
    >> int locked = 1;
    >>
    >
    > Sparse generated this? Or did a broken / old version of gcc?
    >
    Sorry, it's a gcc warning.

    My gcc version is:
    gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973]

    > This patch fixes nothing, sorry, so I can't accept it.
    >
    > greg k-h
    >
    > .
    >




    \
     
     \ /
      Last update: 2015-03-09 10:01    [W:7.002 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site