lkml.org 
[lkml]   [2015]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nits: fix several coding style warnings
From
Date
On Sun, 2015-03-08 at 23:14 +0100, Guennadi Liakhovetski wrote:
> On Sun, 8 Mar 2015, Ioana Antoche wrote:
> > Fix checkpatch.pl warnings such as:
> > * missing blank line after declarations
> > * line over 80 characters
[]
> > @@ -298,8 +299,7 @@ static struct device *next_device(struct klist_iter *i)
> > * count in the supplied callback.
> > */
> > int bus_for_each_dev(struct bus_type *bus, struct device *start,
> > - void *data, int (*fn)(struct device *, void *))
> > -{
> > + void *data, int (*fn)(struct device *, void *)) {
>
> Really curious: is this change (and a similar one below) really fixing a
> style violation?

Nope.

The "for_each" use in a function name confuses checkpatch.
Normally, those are macros.

> > @@ -448,8 +449,7 @@ static struct device_driver *next_driver(struct klist_iter *i)
> > * so it doesn't disappear before returning to the caller.
> > */
> > int bus_for_each_drv(struct bus_type *bus, struct device_driver *start,
> > - void *data, int (*fn)(struct device_driver *, void *))
> > -{
> > + void *data, int (*fn)(struct device_driver *, void *)) {





\
 
 \ /
  Last update: 2015-03-08 23:41    [W:0.051 / U:2.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site